Migrate PowderCalibrator to the one in hexrd #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously using a custom PowderCalibrator class for the "Laue and Powder" calibration in hexrdgui. However, this class is not maintained and no longer works properly. Migrate over to using the PowderCalibrator from hexrd. This one is more maintained and updated. The migration required modifying the data input, since the PowderCalibrator from hexrd expects the input data to be in a different format. There may be some options we should be using and are not using yet. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
Because the instrument gets updated for every iteration, the conversion to cartesian coordinates was being changed for every iteration. This would cause the least squares to diverge significantly. Fix it so that we use a consistent conversion to cartesian coordinates by using a copy of the original HEDMInstrument. This also makes a few small modifications so that it is more consistent with hexrd's InstrumentCalibrator. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
|
@joelvbernier I believe this should be working properly now. There are some very slight differences in the results when compared to the "Auto Powder" method, but I confirmed these slight differences are only caused by a small loss of precision when converting between polar and Cartesian in the "Laue and Powder" workflow. |
joelvbernier
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously using a custom PowderCalibrator class for the
"Laue and Powder" calibration in hexrdgui. However, this class is
not maintained and no longer works properly.
Migrate over to using the PowderCalibrator from hexrd. This one
is more maintained and updated.
The migration required modifying the data input, since the
PowderCalibrator from hexrd expects the input data to be in a different
format.
There may be some options we should be using and are not using yet.